[FFmpeg-devel] [PATCH 1/3] lavf/qsv_vpp: add frame format option

[Li, Zhong]

> From: ffmpeg-devel [mailto:ffmpeg-devel-bounces at ffmpeg.org] On Behalf
> Of Li, Zhong
> Sent: Monday, June 3, 2019 10:59 AM
> To: FFmpeg development discussions and patches
> <ffmpeg-devel at ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH 1/3] lavf/qsv_vpp: add frame format
> option
> 
> > From: ffmpeg-devel [mailto:ffmpeg-devel-bounces at ffmpeg.org] On
> Behalf
> > Of Carl Eugen Hoyos
> > Sent: Saturday, June 1, 2019 4:43 AM
> > To: FFmpeg development discussions and patches
> > <ffmpeg-devel at ffmpeg.org>
> > Subject: Re: [FFmpeg-devel] [PATCH 1/3] lavf/qsv_vpp: add frame format
> > option
> >
> > Am Fr., 31. Mai 2019 um 10:01 Uhr schrieb Zhong Li <zhong.li at intel.com>:
> >
> > > @@ -104,6 +109,8 @@ static const AVOption options[] = {
> > >      { "width",  "Output video width",  OFFSET(ow),
> > AV_OPT_TYPE_STRING, { .str="cw" }, 0, 255, .flags = FLAGS },
> > >      { "h",      "Output video height", OFFSET(oh),
> > AV_OPT_TYPE_STRING, { .str="w*ch/cw" }, 0, 255, .flags = FLAGS },
> > >      { "height", "Output video height", OFFSET(oh),
> > > AV_OPT_TYPE_STRING, { .str="w*ch/cw" }, 0, 255, .flags = FLAGS },
> > > +    { "format", "Output pixel format", OFFSET(output_format_str),
> > > + AV_OPT_TYPE_STRING, { .str = "same" }, .flags = FLAGS },
> >
> > AV_OPT_TYPE_PIXEL_FMT?
> > Or do I miss something?
> >
> > Carl Eugen
> 
> It is a string and converted to AVPixelFormat using av_get_pix_fmt() 
>Keep alignment with vf_scaling_qsv/npp/vaapi.c

Does this answer make sense? If so will push it soon.