[FFmpeg-devel] [PATCH v3 2/3] libavfilter/vf_cover_rect: support for cover image with more pixel format and different width and height

[Lance Wang]

On Wed, Jun 12, 2019 at 5:43 PM Moritz Barsnick <barsnick at gmx.net> wrote:

> On Tue, Jun 11, 2019 at 13:38:43 +0800, lance.lmwang at gmail.com wrote:
> > @@ -220,11 +248,6 @@ static av_cold int init(AVFilterContext *ctx)
> >                                  &cover->cover_frame->width,
> &cover->cover_frame->height,
> >                                  &cover->cover_frame->format,
> cover->cover_filename, ctx)) < 0)
> >              return ret;
> > -
> > -        if (cover->cover_frame->format != AV_PIX_FMT_YUV420P &&
> cover->cover_frame->format != AV_PIX_FMT_YUVJ420P) {
> > -            av_log(ctx, AV_LOG_ERROR, "cover image is not a YUV420
> image\n");
> > -            return AVERROR(EINVAL);
> > -        }
> >      }
>
> Don't you also need to update query_formats()? Just wondering,
> untested.
>
> It's image format only, the patch will convert it to same format as input
frame.  I have tested with the new patch and haven't see any issue.




> Moritz
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".