[FFmpeg-devel] [PATCH] avformat/oggparseogm: unknown codec triggers error

[James Almer]

On 6/14/2019 11:52 AM, Reimar Döffinger wrote:
> 
> 
> On 14.06.2019, at 03:15, Chris Cunningham <chcunningham at chromium.org> wrote:
> 
>> Only "succeed" to read a header if the codec is valid. Otherwise
>> return AVERROR_INVALIDDATA.
> 
> That doesn't sound right to me, an unknown codec in (possibly) a single stream is not an error.
> I understood the discussion more to say the if it's an unknown codec, we should not try to override valid codec configuration with a broken one.

I did request this change, seeing that returning codec_id none in this
scenario results in a crash at a later point due to conflicting parameters.

Do you suggest we should limit the change to only reject any duplicate
header that may show up after the first one (and before the first data
packet)?