[FFmpeg-devel] [PATCH] movenc: calculate track_duration without packet duration

[Derek Buitenhuis]

On 19/06/2019 06:43, Gyan wrote:
>> setting track_duration is inconsistent; some times it includes
>> duration and some times not.
> It may be best to check the commits for these assignments to see if the 
> inconsistency is deliberate.
> The track duration is written into the media header box for the track. I 
> also see it being used elsewhere to adjust dts. Do those roles remain 
> intact?
> 
> Does FATE pass?

Wouldn't the correct fix be to fix the places where duration is *not*
used?

Writing the track duration without taking into account the actual
packet duration of the last packet is just wrong. That's not the
track's duration, and is in fact very problematic for low frame
rate files, such a slide shows; QuickTime will cut off at the
end of the media and track duration, dropping possibly a whole
slide, for example.

- Derek