[FFmpeg-devel] [PATCH] avformat/rtpdec_rfc4175: Fix incorrect copy_offset calculation

Michael Niedermayer michael at niedermayer.cc
Fri Jun 21 01:58:19 EEST 2019


On Thu, Jun 20, 2019 at 06:21:53AM +0000, Jacob Siddall wrote:
> The previous calculation code did not account for the fact that the
> copy_offset for the start of the frame array is at index 0, yet the
> scan line number from the rfc4175 RTP header starts at 1.
> This caused 2 issues to appear:
> - The first scan line was being copied into the array where the second
>   scan line should be. This caused the resulting video to have a green
>   line at the top of it.
> - Since the packet containing the last scan line would fail the
>   calculation, the packet with the RTP marker would not be processed
>   which caused a log message saying "Missed previous RTP marker" to be
>   outputted for each frame.
> 
> Signed-off-by: Jacob Siddall <kobe at live.com.au>
> ---
>  libavformat/rtpdec_rfc4175.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

doesnt apply with git 

Applying: avformat/rtpdec_rfc4175: Fix incorrect copy_offset calculation
Using index info to reconstruct a base tree...
error: patch failed: libavformat/rtpdec_rfc4175.c:206
error: libavformat/rtpdec_rfc4175.c: patch does not apply
error: Did you hand edit your patch?
It does not apply to blobs recorded in its index.
Patch failed at 0001 avformat/rtpdec_rfc4175: Fix incorrect copy_offset calculation

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I do not agree with what you have to say, but I'll defend to the death your
right to say it. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190621/962656b6/attachment.sig>


More information about the ffmpeg-devel mailing list