[FFmpeg-devel] [PATCH 4/4] avcodec/fitsdec: Check data_min/max

[Michael Niedermayer]

On Thu, Jun 13, 2019 at 04:29:54PM +0200, Moritz Barsnick wrote:
> On Thu, Jun 13, 2019 at 01:20:20 +0200, Michael Niedermayer wrote:
> > +        if (header->data_min == header->data_max) {
> 
> Just a note:
> Equality comparison of floats/doubles may trigger a warning. (Possibly
> needs to be explicitly enabled though, like with "-Wfloat-equal" on
> gcc.) Might be okay though nevertheless.

ill post a new patch that reorders this a bit, maybe it doesnt generate
a warning. But using something like DBL_EPSILON is more wrong than the ==
here i think, as it could turn a non blank image into a blank one

thx


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Old school: Use the lowest level language in which you can solve the problem
            conveniently.
New school: Use the highest level language in which the latest supercomputer
            can solve the problem without the user falling asleep waiting.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190625/7077061f/attachment.sig>