[FFmpeg-devel] [PATCH 2/2] avcodec/libdav1d: use a custom picture allocator

[Carl Eugen Hoyos]

2019-03-06 14:22 GMT+01:00, James Almer <jamrial at gmail.com>:
> On 3/6/2019 5:06 AM, Carl Eugen Hoyos wrote:
>> 2019-03-04 22:06 GMT+01:00, James Almer <jamrial at gmail.com>:
>>
>>> +static const enum AVPixelFormat pix_fmt[][3] = {
>>> +    [DAV1D_PIXEL_LAYOUT_I400] = { AV_PIX_FMT_GRAY8,   AV_PIX_FMT_GRAY10,
>>> AV_PIX_FMT_GRAY12 },
>>> +    [DAV1D_PIXEL_LAYOUT_I420] = { AV_PIX_FMT_YUV420P,
>>> AV_PIX_FMT_YUV420P10,
>>> AV_PIX_FMT_YUV420P12 },
>>> +    [DAV1D_PIXEL_LAYOUT_I422] = { AV_PIX_FMT_YUV422P,
>>> AV_PIX_FMT_YUV422P10,
>>> AV_PIX_FMT_YUV422P12 },
>>> +    [DAV1D_PIXEL_LAYOUT_I444] = { AV_PIX_FMT_YUV444P,
>>> AV_PIX_FMT_YUV444P10,
>>> AV_PIX_FMT_YUV444P12 },
>>> +};
>>
>> Looks like a separate change.
>>
>> And please use the ERROR defines.
>>
>> Carl Eugen
>
> You want me to move this array up in the file in a separate commit?

No, I just wanted to carefully remind you that smaller commits
do have advantages.
But this is clearly your code.

Sorry for the noise, Carl Eugen