[FFmpeg-devel] [PATCH v4] avformat/smoothstreamingenc:add bitrate calculate

[Moritz Barsnick]

On Fri, Mar 15, 2019 at 17:21:19 -0700, Jun Li wrote:
> -            av_log(s, AV_LOG_ERROR, "No bit rate set for stream %d\n", i);
> -            ret = AVERROR(EINVAL);
> -            goto fail;
> +            av_log(s, AV_LOG_WARNING, "No bit rate set for stream %"PRId32"\n", i);

i is declared as int, not int32_t, so please stick with %d.

> +            snprintf(os->dirname, sizeof(os->dirname), "%s/QualityLevels(Tmp_%"PRId32")", s->url, i);

Ditto.

> +                av_log(s, AV_LOG_ERROR, "calculating bitrate get zero.");
                                                                ^ "got" or "became"

> +            av_log(s, AV_LOG_WARNING, "calculated bitrate: %"PRId64"\n", bitrate);
                         ^ A warning is meant to warn. This is an information or a debug info.

Moritz