[FFmpeg-devel] [PATCH 2/2] lavf/movdec: use a more appropriate error code for bad trun atoms

Michael Niedermayer michael at niedermayer.cc
Sun Mar 17 12:13:29 EET 2019


On Sat, Mar 16, 2019 at 05:22:03AM -0500, Rodger Combs wrote:
> ---
>  libavformat/mov.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavformat/mov.c b/libavformat/mov.c
> index 0dfee2e7c4..9ed109962f 100644
> --- a/libavformat/mov.c
> +++ b/libavformat/mov.c
> @@ -4785,7 +4785,7 @@ static int mov_read_trun(MOVContext *c, AVIOContext *pb, MOVAtom atom)
>          av_log(c->fc, AV_LOG_ERROR, "Failed to add index entry\n");
>      }
>      if (entries <= 0)
> -        return -1;
> +        return AVERROR_INVALIDDATA;

not sure this is the best error code here but its better than -1

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

There will always be a question for which you do not know the correct answer.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190317/9c0fca0e/attachment.sig>


More information about the ffmpeg-devel mailing list