[FFmpeg-devel] [PATCH] swscale/ppc: VSX-optimize yuv2rgb_full

[Lauri Kasanen]

On Wed, 20 Mar 2019 14:41:27 +0100
Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:

> 2019-03-20 13:37 GMT+01:00, Lauri Kasanen <cand at gmx.com>:
>
> > @@ -480,5 +722,66 @@ av_cold void ff_sws_init_swscale_vsx(SwsContext *c)
>
> Are there followup patches?
> Or why is the following hunk so convoluted?

I plan to add the _2 and _X variants later. I don't know yet if they
need power8; if one doesn't, then there'd be plenty of ifdef sprinkling.

> > +    if (c->flags & SWS_BITEXACT)
> > +        return;
>
> > +#if !HAVE_BIGENDIAN
>
> Are you planning to add big-endian support?

No, I can only test LE.

> > +    if (c->flags & SWS_FULL_CHR_H_INT) {
>
> Iiuc, the first if above and this one can be merged.

I plan to add other formats that are used without that flag.

> > +        switch (dstFormat) {
> > +            case AV_PIX_FMT_RGB24:
>
> > +#if HAVE_POWER8
> > +                if (cpu_flags & AV_CPU_FLAG_POWER8) {
>
> if (HAVE_POWER8 && cpu_flags & AV_CPU_FLAG_POWER8)

Will do.

- Lauri