[FFmpeg-devel] [PATCH] swscale: Remove duplicated code

Lauri Kasanen cand at gmx.com
Mon Mar 25 12:37:37 EET 2019


On Mon, 25 Mar 2019 11:17:38 +0100
Michael Niedermayer <michael at niedermayer.cc> wrote:

> On Sun, Mar 24, 2019 at 01:04:51PM +0200, Lauri Kasanen wrote:
> > In this function, the exact same clamping happens both in the if and unconditionally.
> >
> > Signed-off-by: Lauri Kasanen <cand at gmx.com>
> > ---
> >  libswscale/output.c | 14 --------------
> >  1 file changed, 14 deletions(-)
>
> The removed code is the one that should stay, the other should be
> removed.
> one check for a rarely true condition should be faster than 4 checks

Yes, I thought so too, but the commit that added the unconditional code
says it fixes a bug...

- Lauri


More information about the ffmpeg-devel mailing list