[FFmpeg-devel] [Patch] beautified + accelerated vf_fillborders – Please review

[Ulf Zibis]

Hi again,

Am 25.03.19 um 12:31 schrieb Ulf Zibis:
>> There are two patches "1", one with wrong indentation.
> I intentionally have provided 2 patches with the same number, one for
> the code base an one with additions for the benchmark. I've catched the
> wrong indentation, hopefully at the place you meant.
>
> I'm preparing a new set of patches to follow your advice.
>
>> Do I read the results correctly that for all patches some cases
>> get faster and others get slower?
> Correct. I'm wondering about the cases, where it gets such slower. So
> I'm interested in an answer from you experienced developers to
> understand this. Maybe a compiler option would help.

Here they are, my new set of patches.

The most patches are more or less cosmetic, but good for preparing the
essential patch of #9.

As you can see from the benchmark log included in the
vf_fillbd_benchmark_9.patch I have attained a performance gain up to 45 %.
It is remarkable, that in several cases the processing of 16-bit planes
is often faster as of 8-bit planes of same image dimension.

Regards,

-Ulf


-------------- next part --------------
A non-text attachment was scrubbed...
Name: vf_fillborders_1.patch
Type: text/x-patch
Size: 6730 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190328/91efc471/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vf_fillborders_2.patch
Type: text/x-patch
Size: 6603 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190328/91efc471/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vf_fillborders_3.patch
Type: text/x-patch
Size: 11144 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190328/91efc471/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vf_fillborders_4.patch
Type: text/x-patch
Size: 3644 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190328/91efc471/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vf_fillborders_5.patch
Type: text/x-patch
Size: 668 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190328/91efc471/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vf_fillborders_6.patch
Type: text/x-patch
Size: 10494 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190328/91efc471/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vf_fillborders_7.patch
Type: text/x-patch
Size: 4967 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190328/91efc471/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vf_fillborders_8.patch
Type: text/x-patch
Size: 1162 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190328/91efc471/attachment-0007.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vf_fillborders_9.patch
Type: text/x-patch
Size: 12562 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190328/91efc471/attachment-0008.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vf_fillborders_10.patch
Type: text/x-patch
Size: 9876 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190328/91efc471/attachment-0009.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vf_fillborders_11.patch
Type: text/x-patch
Size: 5384 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190328/91efc471/attachment-0010.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vf_fillbd_benchmark_7.patch
Type: text/x-patch
Size: 27767 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190328/91efc471/attachment-0011.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vf_fillbd_benchmark_8.patch
Type: text/x-patch
Size: 1840 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190328/91efc471/attachment-0012.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vf_fillbd_benchmark_9.patch
Type: text/x-patch
Size: 56627 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190328/91efc471/attachment-0013.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vf_fillbd_benchmark_10.patch
Type: text/x-patch
Size: 12376 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190328/91efc471/attachment-0014.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vf_fillbd_benchmark_11.patch
Type: text/x-patch
Size: 5404 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190328/91efc471/attachment-0015.bin>