[FFmpeg-devel] [PATCH] avcodec/mlp_parser: split off shared code to its own file

[James Almer]

On 5/4/2019 4:36 PM, James Almer wrote:
> On 5/4/2019 4:04 PM, James Almer wrote:
>> Signed-off-by: James Almer <jamrial at gmail.com>
>> ---
>>  libavcodec/Makefile                      |   4 +-
>>  libavcodec/mlp_parse.c                   | 213 +++++++++++++++++++++++
>>  libavcodec/{mlp_parser.h => mlp_parse.h} |  15 +-
>>  libavcodec/mlp_parser.c                  | 193 +-------------------
>>  libavcodec/mlpdec.c                      |   2 +-
>>  libavcodec/truehd_core_bsf.c             |   2 +-
>>  6 files changed, 221 insertions(+), 208 deletions(-)
>>  create mode 100644 libavcodec/mlp_parse.c
>>  rename libavcodec/{mlp_parser.h => mlp_parse.h} (92%)
>>
>> diff --git a/libavcodec/Makefile b/libavcodec/Makefile
>> index f37135fc07..edccd73037 100644
>> --- a/libavcodec/Makefile
>> +++ b/libavcodec/Makefile
>> @@ -1042,7 +1042,7 @@ OBJS-$(CONFIG_H263_PARSER)             += h263_parser.o
>>  OBJS-$(CONFIG_H264_PARSER)             += h264_parser.o h264_sei.o h264data.o
>>  OBJS-$(CONFIG_HEVC_PARSER)             += hevc_parser.o hevc_data.o
>>  OBJS-$(CONFIG_MJPEG_PARSER)            += mjpeg_parser.o
>> -OBJS-$(CONFIG_MLP_PARSER)              += mlp_parser.o mlp.o
>> +OBJS-$(CONFIG_MLP_PARSER)              += mlp_parse.o mlp_parser.o mlp.o
>>  OBJS-$(CONFIG_MPEG4VIDEO_PARSER)       += mpeg4video_parser.o h263.o \
>>                                            mpeg4videodec.o mpeg4video.o \
>>                                            ituh263dec.o h263dec.o h263data.o
>> @@ -1097,7 +1097,7 @@ OBJS-$(CONFIG_PRORES_METADATA_BSF)        += prores_metadata_bsf.o
>>  OBJS-$(CONFIG_REMOVE_EXTRADATA_BSF)       += remove_extradata_bsf.o
>>  OBJS-$(CONFIG_TEXT2MOVSUB_BSF)            += movsub_bsf.o
>>  OBJS-$(CONFIG_TRACE_HEADERS_BSF)          += trace_headers_bsf.o
>> -OBJS-$(CONFIG_TRUEHD_CORE_BSF)            += truehd_core_bsf.o mlp_parser.o mlp.o
>> +OBJS-$(CONFIG_TRUEHD_CORE_BSF)            += truehd_core_bsf.o mlp_parse.o mlp.o
>>  OBJS-$(CONFIG_VP9_METADATA_BSF)           += vp9_metadata_bsf.o
>>  OBJS-$(CONFIG_VP9_RAW_REORDER_BSF)        += vp9_raw_reorder_bsf.o
>>  OBJS-$(CONFIG_VP9_SUPERFRAME_BSF)         += vp9_superframe_bsf.o
>> diff --git a/libavcodec/mlp_parse.c b/libavcodec/mlp_parse.c
>> new file mode 100644
>> index 0000000000..db2531f665
>> --- /dev/null
>> +++ b/libavcodec/mlp_parse.c
>> @@ -0,0 +1,213 @@
>> +/*
>> + * This file is part of FFmpeg.
> 
> Locally added a "Copyright (c) 2007 Ian Caulfield line", same as in
> mlp_parser.c, since the code moved here was effectively written by him
> in the very first mlp parser commit (6b493b2f2f).

Pushed.