[FFmpeg-devel] [PATCH v2 1/2] fftools/ffmpeg_filter, ffplay: Add flip support to rotation

[Jun Li]

On Tue, May 7, 2019 at 3:10 PM Michael Niedermayer <michael at niedermayer.cc>
wrote:

> On Sun, May 05, 2019 at 08:41:27PM -0700, Jun Li wrote:
> > Current implemantion for autoratation does not support flip.
> > That is, if the matrix contains flip info, the API get_rotation
> > only reflects partial information. This change is for adding
> > support for hflip (vflip can be achieved by rotation+hflip).
> > ---
> >  fftools/cmdutils.c        |  4 ++--
> >  fftools/cmdutils.h        |  2 +-
> >  fftools/ffmpeg_filter.c   | 31 ++++++++++++++++++++++++++-----
> >  fftools/ffplay.c          | 22 ++++++++++++++++++----
> >  libavutil/display.c       | 12 ++++++++++++
> >  libavutil/display.h       | 14 ++++++++++++++
> >  libavutil/tests/display.c |  8 ++++++++
> >  tests/ref/fate/display    |  4 ++++
> >  8 files changed, 85 insertions(+), 12 deletions(-)
>
> this caused people to hang from the ceiling in:
> ./ffplay ~/issues/1086/47j9R7PXBep.mov
>
>   Metadata:
>     major_brand     : qt
>     minor_version   : 537199360
>     compatible_brands: qt
>     creation_time   : 2009-05-05T17:20:23.000000Z
>     com.apple.quicktime.player.movie.audio.gain: 1.000000
>     com.apple.quicktime.player.movie.audio.treble: 0.000000
>     com.apple.quicktime.player.movie.audio.bass: 0.000000
>     com.apple.quicktime.player.movie.audio.balance: 0.000000
>     com.apple.quicktime.player.movie.audio.pitchshift: 0.000000
>     com.apple.quicktime.player.movie.audio.mute:
>     com.apple.quicktime.player.movie.visual.brightness: 0.000000
>     com.apple.quicktime.player.movie.visual.color: 1.000000
>     com.apple.quicktime.player.movie.visual.tint: 0.000000
>     com.apple.quicktime.player.movie.visual.contrast: 1.000000
>     com.apple.quicktime.player.version: 7.6 (7.6)
>     com.apple.quicktime.version: 7.6.0 (1290) 0x7608000 (Mac OS X, 10.5.6,
> 9G55)
>     compilation     : 0
>     encoder         : Sorenson Squeeze 4.5
>   Duration: 00:00:30.58, start: 0.000000, bitrate: 2006 kb/s
>     Stream #0:0: Audio: aac (LC) (mp4a / 0x6134706D), 44100 Hz, stereo,
> fltp, 127 kb/s (default)
>     Metadata:
>       rotate          : 0
>       creation_time   : 2009-05-05T17:20:23.000000Z
>       handler_name    : Apple Sound Media Handler
>     Stream #0:1: Video: h264 (Constrained Baseline) (avc1 / 0x31637661),
> yuv420p, 320x240, 1544 kb/s, 29.97 fps, 29.97 tbr, 90k tbn, 180k tbc
> (default)
>     Metadata:
>       rotate          : 0
>       creation_time   : 2009-05-05T17:20:23.000000Z
>       handler_name    : Apple Video Media Handler
>       encoder         : AVC Coding
>     Side data:
>       displaymatrix: rotation of -0.00 degrees
>     Stream #0:2: Data: none (mp4s / 0x7334706D) (default)
>     Metadata:
>       rotate          : 0
>       creation_time   : 2009-05-05T17:20:23.000000Z
>       handler_name    : Apple MPEG-4 Scene Media Handler
>     Stream #0:3: Data: none (mp4s / 0x7334706D) (default)
>     Metadata:
>       rotate          : 0
>       creation_time   : 2009-05-05T17:20:23.000000Z
>       handler_name    : Apple MPEG-4 ODSM Media Handler
>     Stream #0:4(eng): Data: none (rtp  / 0x20707472), 14 kb/s
>     Metadata:
>       rotate          : 0
>       creation_time   : 2009-05-05T17:20:23.000000Z
>       handler_name    : hint media handler
>     Stream #0:5(eng): Data: none (rtp  / 0x20707472), 64 kb/s
>     Metadata:
>       rotate          : 0
>       creation_time   : 2009-05-05T17:20:23.000000Z
>       handler_name    : hint media handler
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> The real ebay dictionary, page 2
> "100% positive feedback" - "All either got their money back or didnt
> complain"
> "Best seller ever, very honest" - "Seller refunded buyer after failed scam"
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".


Thanks Michael for testing.
Do you mind sharing the content "~/issues/1086/47j9R7PXBep.mov" ?

Best Regards,
Jun