[FFmpeg-devel] [PATCH 2/3] swscale: Add support for NV24 and NV42

[Philip Langdale]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On Sun, 12 May 2019 12:54:24 +0200
Michael Niedermayer <michael at niedermayer.cc> wrote:

> 
> all these + 1 in the code above look a bit suspect. Can you explain
> what they do assuming they are intended

Good catch. I should have removed them when I removed the divide by 2.
 
> [...]
> > diff --git a/libswscale/utils.c b/libswscale/utils.c
> > index df68bcc0d9..1b1f779532 100644
> > --- a/libswscale/utils.c
> > +++ b/libswscale/utils.c
> > @@ -264,6 +264,8 @@ static const FormatEntry
> > format_entries[AV_PIX_FMT_NB] = { [AV_PIX_FMT_YUVA422P12LE] = { 1,
> > 1 }, [AV_PIX_FMT_YUVA444P12BE] = { 1, 1 },
> >      [AV_PIX_FMT_YUVA444P12LE] = { 1, 1 },
> > +    [AV_PIX_FMT_NV24]        = { 1, 1 },
> > +    [AV_PIX_FMT_NV42]        = { 1, 1 },  
> 
> nitpick: this can be aligned prettier

They are aligned to the primary alignment within the list. The lines
above are exceptions to the existing pattern due to their length.

Thanks,

- --phil
-----BEGIN PGP SIGNATURE-----

iHUEARYIAB0WIQRokRbWmcX6x+Nv+3hgE8jODULZ6QUCXNgw0gAKCRBgE8jODULZ
6ZHpAPoDp3JcLdqjlWr/mo0luxS0UNHwonKuFU04Dpz8FYkw9AD8DL1DC4czUMT7
qPodwqeGY6xKpeNwf6f7OL78pHP3FAM=
=+hv7
-----END PGP SIGNATURE-----