[FFmpeg-devel] [PATCH v2] libavutil: add an FFT & MDCT implementation

Carl Eugen Hoyos ceffmpeg at gmail.com
Sun May 12 23:38:35 EEST 2019


Am So., 12. Mai 2019 um 22:37 Uhr schrieb Paul B Mahol <onemda at gmail.com>:
>
> On 5/12/19, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
> > Am Fr., 10. Mai 2019 um 17:15 Uhr schrieb Lynne <dev at lynne.ee>:
> >>
> >> Patch updated again.
> >> Made some more cleanups to the transforms, the tables and the main
> >> context.
> >> API changed again, now the init function populates the function pointer
> >> for transform.
> >> I decided that having a separate function would encourage bad usage (e.g.
> >> calling
> >> the function every time before doing a transform rather than storing the
> >> pointer) when
> >> we're trying to avoid the overhead of function calls.
> >> Also adjusted file names to match the API.
> >
> > As said, this patch is not ok as long as the copyright statements are
> > missing.
> >
>
> You are mislead. No statements are necessary.

Why do you think so?

The commit message states that a part of the code is coming
from a file with an extensive copyright statement: Why would
it be ok to remove it?

Carl Eugen


More information about the ffmpeg-devel mailing list