[FFmpeg-devel] [PATCH] libavcodec/qsvenc: fix mpeg2 encoding

[Andreas Håkon]

Hi,

> > Subject: [FFmpeg-devel] [PATCH] libavcodec/qsvenc: fix mpeg2 encoding
> > Fixes bug #7839
> > https://trac.ffmpeg.org/ticket/7839
> > Supersedes:
> > #12935 - https://patchwork.ffmpeg.org/patch/12935/
> > #12872 - https://patchwork.ffmpeg.org/patch/12872/
> > Regards.
> > A.H.
>
> It was saidhttps://patchwork.ffmpeg.org/patch/12935/ could not fix #7839, how this one can work?


I compiled your patch and doesn't work.
My path works.

The difference?
In addition to a few extra little checks, It seems that the
QSV_RUNTIME_VERSION_ATLEAST(q->ver, 1, 11) check fails every time in
Windows (almost in my environment).

Futhermore, it has more sense to apply the check inside the
conditional preprocessing of #if QSV_HAVE_CO3 and not outside.

As a summary: I confirm that my patch works. And it's based on your
proposal. So please comment positively to merge it.

Thank you!
A.H.