[FFmpeg-devel] [PATCH 5/6] avcodec/libvpxdec: decode to custom framebuffers for vp9

[James Zern]

On Sun, Oct 27, 2019 at 10:11 AM Marton Balint <cus at passwd.hu> wrote:
>
> This avoids copying the full frame after decoding.
>
> Signed-off-by: Marton Balint <cus at passwd.hu>
> ---
>  libavcodec/libvpxdec.c | 73 ++++++++++++++++++++++++++++++++++++++++++++++----
>  1 file changed, 68 insertions(+), 5 deletions(-)
>

lgtm.

> diff --git a/libavcodec/libvpxdec.c b/libavcodec/libvpxdec.c
> index 5c72be5439..fdd5d458d3 100644
> [...]
> +    if (min_size > ctx->pool_size) {
> +        av_buffer_pool_uninit(&ctx->pool);
> +        /* According to the libvpx docs the buffer must be zeroed out. */

I think this is stale and may have been only when using msan and
related tools at one point. We can start with this to cover older
versions, but for reference, Chrome doesn't 0 the buffers.