[FFmpeg-devel] [PATCH] fftools/ffmpeg_opt: Fix mixed declarations and code

Michael Niedermayer michael at niedermayer.cc
Wed Nov 6 21:23:39 EET 2019


On Wed, Nov 06, 2019 at 08:08:27PM +0100, Carl Eugen Hoyos wrote:
> Am Mi., 6. Nov. 2019 um 13:18 Uhr schrieb Andreas Rheinhardt
> <andreas.rheinhardt at gmail.com>:
> >
> > Introduced in ed3c317d.
> >
> > Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
> > ---
> >  fftools/ffmpeg_opt.c | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c
> > index af9a9a6acb..f4ccf3f65e 100644
> > --- a/fftools/ffmpeg_opt.c
> > +++ b/fftools/ffmpeg_opt.c
> > @@ -3008,9 +3008,10 @@ static int opt_old2new(void *optctx, const char *opt, const char *arg)
> >  {
> >      OptionsContext *o = optctx;
> >      char *s = av_asprintf("%s:%c", opt + 1, *opt);
> > +    int ret;
> 
> Shouldn't the new declarations be above the call to av_asprintf()?

will apply with that change

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Elect your leaders based on what they did after the last election, not
based on what they say before an election.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20191106/5a96b01f/attachment.sig>


More information about the ffmpeg-devel mailing list