[FFmpeg-devel] avformat/mov: add free memory when error

darling.zhong dalingzhong at yeah.net
Thu Nov 7 14:54:55 EET 2019


Here may have a mem leak when error


Signed-off-by: darling.zhong <dalingzhong at yeah.net>
---
 libavformat/mov.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
 mode change 100644 => 100755 libavformat/mov.c


diff --git a/libavformat/mov.c b/libavformat/mov.c
old mode 100644
new mode 100755
index 4f69664eaf..c2e42ea747
--- a/libavformat/mov.c
+++ b/libavformat/mov.c
@@ -1327,8 +1327,10 @@ static int update_frag_index(MOVContext *c, int64_t offset)
 
     for (i = 0; i < c->fc->nb_streams; i++) {
         // Avoid building frag index if streams lack track id.
-        if (c->fc->streams[i]->id < 0)
+        if (c->fc->streams[i]->id < 0) {
+            av_free(frag_stream_info);
             return AVERROR_INVALIDDATA;
+        }
 
         frag_stream_info[i].id = c->fc->streams[i]->id;
         frag_stream_info[i].sidx_pts = AV_NOPTS_VALUE;
-- 
2.17.1


More information about the ffmpeg-devel mailing list