[FFmpeg-devel] [PATCH 5/8] avformat/mxfdec: Clear metadata_sets_count in mxf_read_close()

[Michael Niedermayer]

On Wed, Nov 06, 2019 at 09:34:01PM +0100, Tomas Härdin wrote:
> tor 2019-10-31 klockan 18:58 +0100 skrev Michael Niedermayer:
> > This avoids problems if the function is called twice
> > 
> > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > ---
> >  libavformat/mxfdec.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c
> > index f3b1b704f9..68a670154b 100644
> > --- a/libavformat/mxfdec.c
> > +++ b/libavformat/mxfdec.c
> > @@ -3582,6 +3582,7 @@ static int mxf_read_close(AVFormatContext *s)
> >      for (i = 0; i < mxf->metadata_sets_count; i++) {
> >          mxf_free_metadataset(mxf->metadata_sets + i, 1);
> >      }
> > +    mxf->metadata_sets_count = 0;
> >      av_freep(&mxf->partitions);
> >      av_freep(&mxf->metadata_sets);
> >      av_freep(&mxf->aesc);
> 
> Looks OK, but I'd work out why close() is called twice

I dont think i saw a case where it was called twice, i just felt
that its more robust to clear this

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Elect your leaders based on what they did after the last election, not
based on what they say before an election.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20191107/de29b498/attachment.sig>