[FFmpeg-devel] [PATCH v1 2/2] avformat/mp3dec: replace SAME_HEADER_MASK with MP3_MASK

[Michael Niedermayer]

On Mon, Nov 11, 2019 at 09:05:02AM +0800, lance.lmwang at gmail.com wrote:
> From: Limin Wang <lance.lmwang at gmail.com>
> 
> mp3 header bitstream syntax:
> header()
> {
>     syncword   12bits bslsf
>     id         1bit    bslsf
>     layer      2bit    bslsf
>     protection_bit 1bit bslsf
>     bitrate_index 4bits bslsf
>     sampling_frequency 2bits bslsf
>     padding_bit  1bit bslsf
>     private_bit 1bit bslsf
>     mode 2bits bslsf
>     mode_extension 2bits bslsf
>     copyright 1bit bslsf
>     original/home 1bit bslsf
>     emphasis 2bits bslsf
> }
> 
> if the header is masking with MP3_MASK(0xFFFE0CCF), below fields will be cleared:
> protection_bit, bitrate_index, sampling_freqency, mode
> 
> with SAME_HEADER_MASK(0xFFFE0C00), extra below fields will be cleared which didn't make
> sense:
> mode_extension, copyright, original/home, emphasis
> 
> As the MP3_MASK is good for same mp3 header masking and is defined in the
> header, so it's preferable to remove SAME_HEADER_MASK to keep the masking same.
> 
> Signed-off-by: Limin Wang <lance.lmwang at gmail.com>
> ---
>  libavformat/mp3dec.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)

will apply this and the previous patch

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 1
"Used only once"    - "Some unspecified defect prevented a second use"
"In good condition" - "Can be repaird by experienced expert"
"As is" - "You wouldnt want it even if you were payed for it, if you knew ..."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20191111/7e8cbf02/attachment.sig>