[FFmpeg-devel] [PATCH 1/5] vcodec/agm: Alloc based on coded dimensions

[Paul B Mahol]

LGTM

On 11/14/19, Michael Niedermayer <michael at niedermayer.cc> wrote:
> Fixes: out of array read
> Fixes:
> 18715/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AGM_fuzzer-5659333417500672
>
> Found-by: continuous fuzzing process
> https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> ---
>  libavcodec/agm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/agm.c b/libavcodec/agm.c
> index 241e9eeb1b..628f324913 100644
> --- a/libavcodec/agm.c
> +++ b/libavcodec/agm.c
> @@ -827,7 +827,7 @@ static int decode_intra(AVCodecContext *avctx,
> GetBitContext *gb, AVFrame *frame
>  static int decode_motion_vectors(AVCodecContext *avctx, GetBitContext *gb)
>  {
>      AGMContext *s = avctx->priv_data;
> -    int nb_mvs = ((avctx->height + 15) >> 4) * ((avctx->width + 15) >> 4);
> +    int nb_mvs = ((avctx->coded_height + 15) >> 4) * ((avctx->coded_width +
> 15) >> 4);
>      int ret, skip = 0, value, map;
>
>      av_fast_padded_malloc(&s->mvectors, &s->mvectors_size,
> --
> 2.23.0
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".