[FFmpeg-devel] [PATCH v2] avfilter: Add tonemap vaapi filter for H2S

[Song, Ruiling]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of
> Carl Eugen Hoyos
> Sent: Thursday, November 28, 2019 2:37 PM
> To: FFmpeg development discussions and patches <ffmpeg-
> devel at ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH v2] avfilter: Add tonemap vaapi filter for
> H2S
> 
> 
> 
> > Am 28.11.2019 um 06:37 schrieb Sun, Xinpeng <xinpeng.sun at intel.com>:
> >
> >>>
> >>> +    if (input_frame->color_trc != AVCOL_TRC_SMPTE2084) {
> >>> +        av_log(avctx, AV_LOG_ERROR, "Only support HDR10 as input for
> vaapi tone-mapping\n");
> >>> +        return AVERROR(EINVAL);
> >>
> >> Shouldn't this also accept unknown trc?
> >> (With a warning)
> >
> > Sorry if I misunderstand "unknown trc". Did you mean the trc undefined by
> ffmpeg or the trc unsupported by the driver?
> 
> My question is:
> If input_frame->color_trc is AVCOL_TRC_UNSPECIFIED, will the above fail?
> But shouldn’t the user be able to use the filter in this case?
Hi Carl,

I am not sure if assuming the input is using SMPTE2084 sounds more acceptable in case of unspecified? If yes, I think we can change as you suggested.
I suggested Xinpeng to follow the behavior of tonemap_opencl for such case, i.e. to fail explicitly for cases other than SMPTE2084. Because people may get incorrect color.

Ruiling
> 
> Thank you for the explanations, Carl Eugen
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".