[FFmpeg-devel] [PATCH v2] avfilter: Add tonemap vaapi filter for H2S

[Sun, Xinpeng]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of Song,
> Ruiling
> Sent: Thursday, November 28, 2019 5:39 PM
> To: FFmpeg development discussions and patches <ffmpeg-devel at ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH v2] avfilter: Add tonemap vaapi filter for
> H2S
> 
> > -----Original Message-----
> > From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of Carl
> > Eugen Hoyos
> > Sent: Thursday, November 28, 2019 5:16 PM
> > To: FFmpeg development discussions and patches <ffmpeg-
> > devel at ffmpeg.org>
> > Subject: Re: [FFmpeg-devel] [PATCH v2] avfilter: Add tonemap vaapi
> > filter for H2S
> >
> > Am Do., 28. Nov. 2019 um 07:56 Uhr schrieb Song, Ruiling
> > <ruiling.song at intel.com>:
> >
> > > > > Am 28.11.2019 um 06:37 schrieb Sun, Xinpeng
> > <xinpeng.sun at intel.com>:
> > > > >
> > > > >>>
> > > > >>> +    if (input_frame->color_trc != AVCOL_TRC_SMPTE2084) {
> > > > >>> +        av_log(avctx, AV_LOG_ERROR, "Only support HDR10 as
> > > > >>> + input
> > for
> > > > vaapi tone-mapping\n");
> > > > >>> +        return AVERROR(EINVAL);
> > > > >>
> > > > >> Shouldn't this also accept unknown trc?
> > > > >> (With a warning)
> > > > >
> > > > > Sorry if I misunderstand "unknown trc". Did you mean the trc
> > undefined by
> > > > ffmpeg or the trc unsupported by the driver?
> > > >
> > > > My question is:
> > > > If input_frame->color_trc is AVCOL_TRC_UNSPECIFIED, will the above fail?
> > > > But shouldn’t the user be able to use the filter in this case?
> > >
> > > I am not sure if assuming the input is using SMPTE2084 sounds more
> > acceptable
> > > in case of unspecified? If yes, I think we can change as you suggested.
> >
> > (Me neither.)
> > A warning could be shown instead of failing.

Prompt the user that the input could only be HDR10 with a warning instead of failing, which sounds good and makes sense. 
I will fix it in the next version.

Thanks,
Xinpeng

> Adding a warning sound good idea. But in order to proceed the tone-mapping, a
> default input transfer-function need to be chosen, which I think we can use
> SMPTE2084 here.

Without any other comments on it, I will use SMPTE2084 as default input transfer-function if input_frame->color_trc is AVCOL_TRC_UNSPECIFIED.

> 
> Ruiling
> >
> > Carl Eugen
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel at ffmpeg.org
> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> > To unsubscribe, visit link above, or email
> > ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email ffmpeg-devel-request at ffmpeg.org
> with subject "unsubscribe".