[FFmpeg-devel] [PATCH 1/6] avcodec/aacdec_template: Check samplerate
Michael Niedermayer
michael at niedermayer.cc
Wed Oct 9 13:14:49 EEST 2019
A value above INT_MAX/2 can overflow in SBR
Fixes: signed integer overflow: 2 * 1881153568 cannot be represented in type 'int'
Fixes: 17996/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AAC_FIXED_fuzzer-5687126468853760
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
---
libavcodec/aacdec_template.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/libavcodec/aacdec_template.c b/libavcodec/aacdec_template.c
index 8726c8b828..75da4eb69a 100644
--- a/libavcodec/aacdec_template.c
+++ b/libavcodec/aacdec_template.c
@@ -1157,6 +1157,9 @@ static av_cold int aac_decode_init(AVCodecContext *avctx)
AACContext *ac = avctx->priv_data;
int ret;
+ if (avctx->sample_rate > INT_MAX/2)
+ return AVERROR_INVALIDDATA;
+
ret = ff_thread_once(&aac_table_init, &aac_static_table_init);
if (ret != 0)
return AVERROR_UNKNOWN;
--
2.23.0
More information about the ffmpeg-devel
mailing list