[FFmpeg-devel] [PATCH v1] avfilter/f_metadata: remove unneeded code

Steven Liu lq at chinaffmpeg.org
Thu Oct 10 09:07:13 EEST 2019



> 在 2019年10月10日,14:03,lance.lmwang at gmail.com 写道:
> 
> From: Limin Wang <lance.lmwang at gmail.com>
> 
> Signed-off-by: Limin Wang <lance.lmwang at gmail.com>
> ---
> libavfilter/f_metadata.c | 4 ----
> 1 file changed, 4 deletions(-)
> 
> diff --git a/libavfilter/f_metadata.c b/libavfilter/f_metadata.c
> index 2ed1393cba..3bf4bb17f5 100644
> --- a/libavfilter/f_metadata.c
> +++ b/libavfilter/f_metadata.c
> @@ -320,13 +320,11 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *frame)
>             av_dict_set(metadata, s->key, s->value, 0);
>         }
>         return ff_filter_frame(outlink, frame);
> -        break;
>     case METADATA_MODIFY:
>         if (e && e->value) {
>             av_dict_set(metadata, s->key, s->value, 0);
>         }
>         return ff_filter_frame(outlink, frame);
> -        break;
>     case METADATA_PRINT:
>         if (!s->key && e) {
>             s->print(ctx, "frame:%-4"PRId64" pts:%-7s pts_time:%s\n",
> @@ -341,7 +339,6 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *frame)
>             s->print(ctx, "%s=%s\n", s->key, e->value);
>         }
>         return ff_filter_frame(outlink, frame);
> -        break;
>     case METADATA_DELETE:
>         if (!s->key) {
>             av_dict_free(metadata);
> @@ -349,7 +346,6 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *frame)
>             av_dict_set(metadata, s->key, NULL, 0);
>         }
>         return ff_filter_frame(outlink, frame);
> -        break;
>     default:
>         av_assert0(0);
>     };
> -- 
> 2.21.0
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".

LGTM

Thanks
Steven







More information about the ffmpeg-devel mailing list