[FFmpeg-devel] [PATCH v3 2/3] avformat/mpjpegdec: fix strict boundary search string

[Michael Niedermayer]

On Thu, Oct 10, 2019 at 11:28:47AM +0200, Moritz Barsnick wrote:
> On Wed, Oct 09, 2019 at 16:34:37 +0200, Michael Niedermayer wrote:
> > > If you want to support both interpretations, you'd need to search for
> > > two different boundaries now. Quite some bloat, if you ask me. I don't
> > > know if it's worth the effort, i.e. whether this will even hit anyone,
> > > as "-strict_mime_boundary" is off by default.
> >
> > I hoped that this server version can easily be detected so only one
> > search is needed
> 
> Sure, it announces itself in the reply headers with
> Server: Motion/X.Y.Z
> 
> I'm not sure ffmpeg evaluates all headers yet. The boundary is fetched
> from the headers of the URL with
> 
> av_opt_get(pb, "mime_type", AV_OPT_SEARCH_CHILDREN, &mime_type);
> 
> Otherwise we'd need the heuristics named in the previous mail.
> 
> > > I vote against, but I probably don't decide.
> >
> > I abstain from voting, was more a thought that more stuff working out
> > of the box wouldnt be bad
> 
> Who decides, and who pushes? Can we perhaps get this patch set through
> and fix this up later?

ok, will apply

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Asymptotically faster algorithms should always be preferred if you have
asymptotical amounts of data
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20191012/bb0faa9d/attachment.sig>