[FFmpeg-devel] [PATCH 01/14] avutil/opt: add AV_OPT_FLAG_RUNTIME_PARAM flag

[Paul B Mahol]

On 10/13/19, Nicolas George <george at nsup.org> wrote:
> Paul B Mahol (12019-10-10):
>> Signed-off-by: Paul B Mahol <onemda at gmail.com>
>> ---
>>  libavutil/opt.h | 1 +
>>  1 file changed, 1 insertion(+)
>
> The patch series looks reasonable on the whole. It changes the return
> code of process_command() in a few cases, but that should not have
> consequences.
>
> But it is completely missing the user documentation. I suggest to add a
> paragraph like that at the appropriate place:
>
>     Changing options at runtime with a command.
>
>     Some options can be changed during the operation of the filter using
>     a command. These options are marked 'R' on the output of `ffmpeg -h
>     filter=...`. The name of the command is the name of the option and
>     the argument is the new value.

R is already taken for realtime option.
Another patch uses T for this.

>
> Then, for each option newly marked with this flag:
>
>     This option can be changed at runtime with a command. See *Changing
>     options at runtime with a command.* for details.
>
> I think that should be enough.
>
> Regards,
>
> --
>   Nicolas George
>