[FFmpeg-devel] [PATCH] avfilter/vf_adadenoise: add x86 SIMD

[James Almer]

On 10/15/2019 12:55 PM, Paul B Mahol wrote:
> On 10/15/19, James Almer <jamrial at gmail.com> wrote:
>> On 10/15/2019 12:21 PM, Paul B Mahol wrote:
>>> +;------------------------------------------------------------------------------
>>> +; void ff_filter_row(const uint8_t *src, uint8_t *dst,
>>> +;                    const uint8_t **srcf,
>>> +;                    int w, int mid, int size,
>>> +;                    int thra, int thrb)
>>> +;------------------------------------------------------------------------------
>>> +
>>> +INIT_XMM sse4
>>> +cglobal atadenoise_filter_row8, 8,12,13, src, dst, srcf, w, mid, size,
>>> thra, thrb, i, j, srcfx, x
>>
>> You need to sign extend all the int argument. And if you're not using
>> thra and thrb, then don't load them and save two gprs.
> 
> Sorry but they are used.

You're loading them from memory manually using r6m and r7m after having
the prologue code load them to gprs in the cglobal line. Since you don't
need them in r6q and r7q, just reuse them for i and j.