[FFmpeg-devel] [PATCH] avfilter/af_arnndn: Remove superfluous qualifier

Andreas Rheinhardt andreas.rheinhardt at gmail.com
Thu Oct 17 12:24:55 EEST 2019


remove_doubling() returned a const float, but returning qualified types
is pointless anyway. This is all the more important given that  GCC 4.2.1
(and maybe other compilers, too) seems to treat this as an error as several
FATE units that don't compile any more show.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
---
Example compilation log:
http://fate.ffmpeg.org/log.cgi?slot=x86_64-openbsd5.6-gcc4.2&time=20191012220632&log=compile

 libavfilter/af_arnndn.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libavfilter/af_arnndn.c b/libavfilter/af_arnndn.c
index 7688b31b0c..7a26f89709 100644
--- a/libavfilter/af_arnndn.c
+++ b/libavfilter/af_arnndn.c
@@ -782,8 +782,8 @@ static float compute_pitch_gain(float xy, float xx, float yy)
 }
 
 static const int second_check[16] = {0, 0, 3, 2, 3, 2, 5, 2, 3, 2, 3, 2, 5, 2, 3, 2};
-static const float remove_doubling(float *x, int maxperiod, int minperiod,
-                                   int N, int *T0_, int prev_period, float prev_gain)
+static float remove_doubling(float *x, int maxperiod, int minperiod, int N,
+                             int *T0_, int prev_period, float prev_gain)
 {
     int k, i, T, T0;
     float g, g0;
-- 
2.20.1



More information about the ffmpeg-devel mailing list