[FFmpeg-devel] [PATCH 4/5] doc/indevs: Add examples for libdc1394

[Forest Crossman]

On Sun, Oct 20, 2019 at 5:21 AM Gyan <ffmpeg at gyani.pro> wrote:
>
> This patch (and others in this set) appear to have been sent multiple
> times. This is the latest received one, so reviewing this one.

Interesting, sorry about that. I only ran git send-email once, but I
did notice that the messages arrived out-of-order in Patchwork and the
list archive--maybe there was a delivery issue somewhere and either
Google or the list server re-sent the messages?

> > + at item
> > +Grab and record the input of an Apple iSight, using the shorter options.
> > + at example
> > +ffmpeg -f libdc1394 -pix_fmt uyvy422 -s 320x240 -r 30 -i auto out.mkv
> > + at end example
>
> The shorter options are deprecated and aren't strictly speaking, private
> options of this device, so remove this example.

Oops, didn't realize those were deprecated, will fix for v2.

> > + at item
> > +Grab and record the input of an Apple iSight, specifying the framerate
> > +as a ratio.
> > + at example
> > +ffmpeg -f libdc1394 -pix_fmt uyvy422 -s 320x240 -r 30000:1000 -i auto out.mkv
> > + at end example
>
> Not really necessary, but if kept, replace with device options.

Got it, in that case I'll just remove it.

> > + at item
> > +Grab and record the input of an Apple iSight at a greater resolution but
> > +a lower framerate.
> > + at example
> > +ffmpeg -f libdc1394 -pix_fmt uyvy422 -s 640x480 -r 15 -i auto out.mkv
> > + at end example
>
> Unless there are restrictions on combinations of option values, seems
> unnecessary.

While there isn't an inherent restriction, devices only support a
limited number of video modes, and in each of those modes only certain
frame rates are supported. I added this example to demonstrate that
other video modes/frame rates could be used, but since the other
examples use this resolution/frame rate combo this example does seem a
bit redundant, so I'll remove it.

> > + at item
> > +Grab and record the input of a specific Apple iSight.
> > + at example
> > +ffmpeg -f libdc1394 -pix_fmt uyvy422 -s 640x480 -r 15 -i 0x000a270004106ea3 out.mkv
> > + at end example
>
> Replace with device options.

Done.

> > + at item
> > +Grab and record the second stream from a specific camera that has
> > +multiple units.
> > + at example
> > +ffmpeg -f libdc1394 -pix_fmt uyvy422 -s 640x480 -r 15 -i 0xfacade02bc394f15:1 out.mkv
> > + at end example
>
> Same.

Done.