[FFmpeg-devel] [PATCH 3/9] avformat/matroskaenc: Use smaller types
Andreas Rheinhardt
andreas.rheinhardt at gmail.com
Tue Oct 22 02:45:00 EEST 2019
James Almer:
> On 10/15/2019 8:17 AM, Andreas Rheinhardt wrote:
>> Several members of structures denote offsets inside dynamic buffers and
>> therefore always fit into an int. So it is unnecessary to use an int64_t
>> for them.
>
> True, but they are set using avio_tell() and then passed to avio_seek(),
> both of which expect int64_t. This change may result in some pedantic
> compilers warning about that conversion.
>
> I don't really see the benefit in doing his. The struct size gains are
> minimal.
>
Ok, I'll remove it.
- Andreas
More information about the ffmpeg-devel
mailing list