[FFmpeg-devel] [PATCH] mpegvideo_enc: add option to disable intra mbs in p frames

[Ramiro Polla]

On Sun, Jun 17, 2018 at 6:23 AM Ramiro Polla <ramiro.polla at gmail.com> wrote:
> On Sun, Jun 10, 2018 at 2:32 AM, Michael Niedermayer
> <michael at niedermayer.cc> wrote:
> > On Sat, Jun 09, 2018 at 05:09:13PM +0200, Ramiro Polla wrote:
> >> On Thu, May 10, 2018 at 11:01 PM, Michael Niedermayer
> >> <michael at niedermayer.cc> wrote:
> >> > On Wed, May 09, 2018 at 08:44:25PM +0200, Ramiro Polla wrote:
> >> >> This option prevents the mpv encoders from using intra macroblocks in
> >> >> predictive frames.
> >> >>
> >> >> It is useful for glitch artists to generate input material. This option
> >> >> allows them to split and merge two video files while maintaining fluid
> >> >> motion from the second video without having intra macroblocks restoring
> >> >> chunks of the first video.
> >> >
> >> > maybe a continuous variable like snows intra_penalty could achieve this
> >> > too but give more flexibility in doing it also just partially if wanted
> >>
> >> I like this idea better. I wanted a simple way to be able to entirely
> >> disable intra macroblocks, but "-intra_penalty max" could cause an
> >> overflow, so I set the max value to INT_MAX/2.
> >>
> >> New patch attached.
> >
> > LGTM
> >
> > a fate test may also make sense
>
> I sent a new patch set that includes a fate test.

The patchset with test that I had sent involved some changes to
ffprobe/fate that weren't good. I gave up trying to add tests in a
clean way.

Here's just the previous LGTM'd patch, rebased against git master.

Ramiro
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-mpegvideo_enc-add-intra_penalty-option-for-p-frames.patch
Type: text/x-patch
Size: 6411 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20191023/ff0d4208/attachment.bin>