[FFmpeg-devel] [PATCH] avfilter/f_sidedata: fix Wtautological-constant-out-of-range-compare

Paul B Mahol onemda at gmail.com
Wed Oct 30 12:58:15 EET 2019


LGTM

On 10/15/19, Zhao Zhili <quinkblack at foxmail.com> wrote:
> ---
> How about add AV_FRAME_DATA_NONE to AVFrameSideDataType?
>
>  libavfilter/f_sidedata.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavfilter/f_sidedata.c b/libavfilter/f_sidedata.c
> index 381da5a052..4210dcac4c 100644
> --- a/libavfilter/f_sidedata.c
> +++ b/libavfilter/f_sidedata.c
> @@ -39,7 +39,7 @@ typedef struct SideDataContext {
>      const AVClass *class;
>
>      int mode;
> -    enum AVFrameSideDataType type;
> +    int type;   // enum AVFrameSideDataType or -1 for delete side data mode
>  } SideDataContext;
>
>  #define OFFSET(x) offsetof(SideDataContext, x)
> --
> 2.21.0
>
>
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".


More information about the ffmpeg-devel mailing list