[FFmpeg-devel] [PATCH] avcodec/webp: avoid trying to decode trailing junk in bitstreams

[Michael Niedermayer]

On Mon, Sep 09, 2019 at 11:13:53AM +0200, Pascal Massimino wrote:
> Michael,
> 
> On Fri, Sep 6, 2019 at 6:21 PM Michael Niedermayer <michael at niedermayer.cc>
> wrote:
> 
> > On Fri, Sep 06, 2019 at 01:11:50PM +0200, Pascal Massimino wrote:
> > > Michael,
> > >
> > > On Thu, Sep 5, 2019 at 6:20 PM Michael Niedermayer
> > <michael at niedermayer.cc>
> > > wrote:
> > >
> > > > On Wed, Sep 04, 2019 at 07:43:15AM +0200, Pascal Massimino wrote:
> > [...]
> >
> > > >
> > > > i would guess its not a known chunk but rather hits the default
> > > > is that just a bunch of 0 or 0xFF bytes ?
> > > > detecting before we read into the end feels more robust if
> > > > we can simply detect the "junk"
> > > >
> > >
> > > As i mentioned in the description, a possibly more robust solution would
> > be
> > > just stopping the loop as soon as 'chunk_size' bytes have been consumed
> > > (leading to *got_frame = 1) and no more. This current patch is
> > minimalist,
> > > though.
> >
> > well, which solution do you prefer ?
> >
> 
> the one in the patch is fine.

ok, will apply

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you drop bombs on a foreign country and kill a hundred thousand
innocent people, expect your government to call the consequence
"unprovoked inhuman terrorist attacks" and use it to justify dropping
more bombs and killing more people. The technology changed, the idea is old.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190910/f67b87fb/attachment.sig>