[FFmpeg-devel] [PATCH v1] libavutil: add A2R10G10B10 & A2B10G10R10

[Zhou, Zachary]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of Carl
> Eugen Hoyos
> Sent: Wednesday, September 11, 2019 7:30 AM
> To: FFmpeg development discussions and patches <ffmpeg-devel at ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH v1] libavutil: add A2R10G10B10 &
> A2B10G10R10
> 
> Am Di., 10. Sept. 2019 um 11:35 Uhr schrieb Zachary Zhou
> <zachary.zhou at intel.com>:
> >
> > ---
> >  libavutil/hwcontext_vaapi.c | 6 ++++++
> >  libavutil/pixfmt.h          | 3 +++
> >  2 files changed, 9 insertions(+)
> >
> > diff --git a/libavutil/hwcontext_vaapi.c b/libavutil/hwcontext_vaapi.c
> > index cf117640f2..9838250b66 100644
> > --- a/libavutil/hwcontext_vaapi.c
> > +++ b/libavutil/hwcontext_vaapi.c
> > @@ -125,6 +125,12 @@ static const VAAPIFormatDescriptor
> > vaapi_format_map[] = {  #endif
> >      MAP(BGRA, RGB32,   BGRA, 0),
> >      MAP(BGRX, RGB32,   BGR0, 0),
> > +#ifdef VA_FOURCC_A2R10G10B10
> > +    MAP(A2R10G10B10, RGB32_10, A2R10G10B10, 0), #endif #ifdef
> > +VA_FOURCC_A2B10G10R10
> > +    MAP(A2B10G10R10, RGB32_10, A2B10G10R10, 0), #endif
> >      MAP(RGBA, RGB32,   RGBA, 0),
> >      MAP(RGBX, RGB32,   RGB0, 0),
> >  #ifdef VA_FOURCC_ABGR
> > diff --git a/libavutil/pixfmt.h b/libavutil/pixfmt.h index
> > d78e863d4b..e00f129b46 100644
> > --- a/libavutil/pixfmt.h
> > +++ b/libavutil/pixfmt.h
> > @@ -348,6 +348,9 @@ enum AVPixelFormat {
> >      AV_PIX_FMT_NV24,      ///< planar YUV 4:4:4, 24bpp, 1 plane for Y and 1
> plane for the UV components, which are interleaved (first byte U and the
> following byte V)
> >      AV_PIX_FMT_NV42,      ///< as above, but U and V bytes are swapped
> >
> > +    AV_PIX_FMT_A2R10G10B10, ///< 10-bit Pixel RGB formats.
> > +    AV_PIX_FMT_A2B10G10R10, ///< 10-bit Pixel BGR formats.
> 
> The patch looks insufficient, see the patch to add AYUV and other packed
> formats.

Thank you for the review, I will refer these patches.

> 
> The more important question imo is: Why are these formats needed, which
> hardware produces them for which input?

These formats target to Intel Ice Lake platform. will be use in HDR tone mapping filter.
input is P010.

welcome to review my HDR patch: https://patchwork.ffmpeg.org/patch/15018/
I appreciate any comments.

-Zachary

> 
> Carl Eugen
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email ffmpeg-devel-request at ffmpeg.org
> with subject "unsubscribe".