[FFmpeg-devel] [PATCH v2 2/3] avformat/hashenc: use an array of hashes

[Moritz Barsnick]

On Wed, Sep 11, 2019 at 10:39:40 -0300, James Almer wrote:
> On 9/11/2019 10:34 AM, Moritz Barsnick wrote:
> > +static void hash_free(struct AVFormatContext *s)
> > +{
> > +    struct HashContext *c = s->priv_data;
> > +    av_hash_freep(&c->hashes[0]);
>
> AVOutputFormat.deinit() is called when AVOutputFormat.init() fails, so
> c->hashes can be NULL. same with the framehash muxer.
>
> > +    av_freep(&c->hashes);
> > +}

Does this mean there should just be a check for "if (c->hashes)" here,
or can the suggestion in
http://ffmpeg.org/pipermail/ffmpeg-devel/2019-August/248014.html
actually not be implemented? No common freeing function?

Thanks,
Moritz