[FFmpeg-devel] [PATCH 2/2] avcodec/vp56rac: delay signaling an error on truncated input

[Michael Niedermayer]

On Tue, Aug 20, 2019 at 11:51:49AM +0200, Michael Niedermayer wrote:
> A threshold of 1 is sufficient for simple_dump_cut.webm, 10 is used
> just to be sure the next truncated file doesnt cause the same issue
> 
> Obvious alternative fixes are to simply accept that the file is broken or to
> write some advanced error concealment or to
> simply accept that the decoder wont stop at the end of input.
> 
> Fixes: Ticket 8069 (artifacts not the differing md5 which was there before 1afd246960202917e244c844c534e9c1e3c323f5)
> Fixes: simple_dump_cut.webm
> Fixes: regression of 1afd246960202917e244c844c534e9c1e3c323f5
> 
> fate-vp5 changes because the last frame is truncated and now handled
> differently.
> 
> Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> ---
>  libavcodec/vp56.h    | 5 ++++-
>  libavcodec/vp56rac.c | 1 +
>  tests/ref/fate/vp5   | 2 +-
>  3 files changed, 6 insertions(+), 2 deletions(-)

will apply

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Awnsering whenever a program halts or runs forever is
On a turing machine, in general impossible (turings halting problem).
On any real computer, always possible as a real computer has a finite number
of states N, and will either halt in less than N cycles or never halt.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190911/43a950a6/attachment.sig>