[FFmpeg-devel] FW: [PATCH] Add option to log timing

[Michael Niedermayer]

On Thu, Sep 12, 2019 at 09:40:48PM +0000, Soft Works wrote:
> 
> 
> > -----Original Message-----
> > From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of
> > Michael Niedermayer
> > Sent: Thursday, September 12, 2019 11:29 PM
> > To: FFmpeg development discussions and patches <ffmpeg-
> > devel at ffmpeg.org>
> > Subject: Re: [FFmpeg-devel] FW: [PATCH] Add option to log timing
> > 
> > On Wed, Sep 11, 2019 at 08:43:36PM +0000, Soft Works wrote:
> > > Michael - you probably missed my question...
> > >
> > > -----Original Message-----
> > > From: Soft Works
> > > Sent: Friday, September 6, 2019 11:44 PM
> > > To: FFmpeg development discussions and patches
> > > <ffmpeg-devel at ffmpeg.org>
> > > Subject: RE: [FFmpeg-devel] [PATCH] Add option to log timing
> > >
> > > > From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of
> > > > Michael Niedermayer
> > > > Sent: Friday, September 6, 2019 8:56 PM
> > > > To: FFmpeg development discussions and patches <ffmpeg-
> > > > devel at ffmpeg.org>
> > > > Subject: Re: [FFmpeg-devel] [PATCH] Add option to log timing
> > > >
> > > > On Wed, Sep 04, 2019 at 07:35:11PM +0000, Soft Works wrote:
> > > > >
> > > > > > Why this restriction? I think all log lines should be start with
> > > > > > time/date if corresponding flag is present. This makes the log
> > > > > > to be easy to parse by scripts.
> > > > >
> > > > > Initially I didn’t have this restriction, but it doesn’t work well
> > > > > together with
> > > > some multi-line logging.
> > > > > See below for an example.
> > > > >
> > > > > To get this nice, it would require a larger amount of changes, and
> > > > > probably
> > > > result in something that nobody wants to merge in.
> > > > >
> > > > > Anyway, there’s a flag controlling this behavior and if you really
> > > > > want, you
> > > > can set it.
> > > > > Then you’ll see something like this:
> > >
> > > [...]
> > >
> > > > i just enabled prefixes for all calls, and i get this:
> > > >
> > > > []   libavutil      56. 35.100 / 56. 35.100
> > > > []   libavcodec     58. 56.101 / 58. 56.101
> > >
> > > [...]
> > >
> > > >
> > > > This looks much better than your example, so i have to disagree that
> > > > theres a problem for calls during startup or some requirment of high
> > > > complexity
> > >
> > > I need to apologize. I had been driven by another complication that exists
> > in my branch but not in the ffmpeg trunk.
> > >
> > >
> > > I will submit an updated patch.
> > >
> > > What would you prefer - should I:
> > >
> > > 1. Activate the flag for adding log timing  during startup by default
> > >   (to allow opt-out behavior from the command line) or 2. Remove that
> > > flag and add log timing either all or nothing depending
> > >    On the other two flags?
> > 
> > i think i dont understand the question fully
> > 
> > The default behavior should not change
> > there could be one or 2 flags that control the timestamp output, yes
> 
> What I meant was whether to keep that third flag for controlling whether
> the timing should be printed from the very first line (default) or just
> be printed once transcoding has started.

if the timing is needed, printing it from the very begin seems more
"expected". 
What is the usecase for not prining it from thr very start ?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When the tyrant has disposed of foreign enemies by conquest or treaty, and
there is nothing more to fear from them, then he is always stirring up
some war or other, in order that the people may require a leader. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190913/9ef99d58/attachment.sig>