[FFmpeg-devel] [PATCH v1 1/4] avutil/avstring: support input path is a null pointer or empty string

[Liu Steven]

> 在 2019年9月16日，下午4:19，Tomas Härdin <tjoppen at acc.umu.se> 写道：
> 
> mån 2019-09-16 klockan 09:03 +0800 skrev lance.lmwang at gmail.com:
>> From: Limin Wang <lance.lmwang at gmail.com>
>> 
>> Signed-off-by: Limin Wang <lance.lmwang at gmail.com>
>> ---
>> libavutil/avstring.c | 12 ++++++++----
>> libavutil/avstring.h | 13 +++++++++----
>> 2 files changed, 17 insertions(+), 8 deletions(-)
>> 
>> diff --git a/libavutil/avstring.c b/libavutil/avstring.c
>> index 4c068f5bc5..9fddd0c77b 100644
>> --- a/libavutil/avstring.c
>> +++ b/libavutil/avstring.c
>> @@ -257,8 +257,12 @@ char *av_strireplace(const char *str, const char
>> *from, const char *to)
>> 
>> const char *av_basename(const char *path)
>> {
>> -    char *p = strrchr(path, '/');
>> +    char *p = NULL;
>> +
>> +    if (!path || *path == '\0')
>> +        return ".";
> 
> I will note here that this kind of thing would go great with a contract
> on the function prototype, so that callers could formally verify that
> they can indeed remove the NULL checks, and that the result of
> av_basename() is always a valid string..
> 
> The patch itself is probably fine
+1
> 
> /Tomas
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".