[FFmpeg-devel] [PATCH 5/5] avformat/utils: Fix always true check

Andreas Rheinhardt andreas.rheinhardt at gmail.com
Mon Sep 16 18:55:02 EEST 2019


Found via PVS-Studio (ticket #8156).

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
---
 libavformat/utils.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavformat/utils.c b/libavformat/utils.c
index b83a740500..1cd7aa211c 100644
--- a/libavformat/utils.c
+++ b/libavformat/utils.c
@@ -4837,7 +4837,7 @@ int ff_mkdir_p(const char *path)
         }
     }
 
-    if ((*(pos - 1) != '/') || (*(pos - 1) != '\\')) {
+    if ((*(pos - 1) != '/') && (*(pos - 1) != '\\')) {
         ret = mkdir(temp, 0755);
     }
 
-- 
2.20.1



More information about the ffmpeg-devel mailing list