[FFmpeg-devel] [PATCH 03/23] lavc/movtextdec: fix bold, italic, underline flags

[Philip Langdale]

On Mon, 6 Apr 2020 11:51:58 -0600
John Stebbins <jstebbins at jetheaddev.com> wrote:

> They should be 0 or 1 so that 0 or -1 is written to the ass header
> ---
>  libavcodec/movtextdec.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/libavcodec/movtextdec.c b/libavcodec/movtextdec.c
> index 47a8401119..d6896562c2 100644
> --- a/libavcodec/movtextdec.c
> +++ b/libavcodec/movtextdec.c
> @@ -193,9 +193,9 @@ static int mov_text_tx3g(AVCodecContext *avctx,
> MovTextContext *m) tx3g_ptr += 2;
>      // face-style-flags
>      s_default.style_flag = *tx3g_ptr++;
> -    m->d.bold = s_default.style_flag & STYLE_FLAG_BOLD;
> -    m->d.italic = s_default.style_flag & STYLE_FLAG_ITALIC;
> -    m->d.underline = s_default.style_flag & STYLE_FLAG_UNDERLINE;
> +    m->d.bold = !!(s_default.style_flag & STYLE_FLAG_BOLD);
> +    m->d.italic = !!(s_default.style_flag & STYLE_FLAG_ITALIC);
> +    m->d.underline = !!(s_default.style_flag & STYLE_FLAG_UNDERLINE);
>      // fontsize
>      m->d.fontsize = *tx3g_ptr++;
>      // Primary color

LGTM.

--phil