[FFmpeg-devel] [PATCH v2 3/7] avformat/hlsenc: Check some unchecked allocations

[Nicolas George]

Steven Liu (12020-04-09):
> I think every body have themselves reason to checking memory and remove the checking at here.
> Whatever for me you can add them here for somebody copy, other body remove them 
> some days(maybe long time later) some body remove remove the for unnecessary processing.

I don't understand what you are trying to say.

The removal of the checks was done at the same time the string functions
were twisted to make them accept NULL. Nobody would propose to re-remove
them unless they are very familiar with the code.

As it is, the code path for the check has been made to start in
libavformat, make a detour through libavutil and come back to
libavformat. This is terrible.

Let us re-add proper, clear checks where they belong.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200409/7f9ddaf1/attachment.sig>