[FFmpeg-devel] [PATCH 08/10] lavc/libopenh264enc: add profile high option support

[Anton Khirnov]

Quoting Linjie Fu (2020-04-06 13:14:51)
> Add support for PRO_HIGH/PRO_BASELINE in SVC Encoding extention mode,
> which determined by iEntropyCodingModeFlag in ParamTranscode().
> 
> <https://github.com/cisco/openh264/blob/master/codec/encoder/core/inc/param_svc.h#L394>
> 
> Signed-off-by: Linjie Fu <linjie.fu at intel.com>
> ---
>  libavcodec/libopenh264enc.c | 32 ++++++++++++++++++++++++++------
>  1 file changed, 26 insertions(+), 6 deletions(-)
> 
> diff --git a/libavcodec/libopenh264enc.c b/libavcodec/libopenh264enc.c
> index f02c5fd..d331cfd 100644
> --- a/libavcodec/libopenh264enc.c
> +++ b/libavcodec/libopenh264enc.c
> @@ -42,7 +42,7 @@ typedef struct SVCContext {
>      ISVCEncoder *encoder;
>      int slice_mode;                 // deprecated
>      int loopfilter;
> -    char *profile;
> +    int profile;

Wouldn't it be better to deprecate the encoder-private option and use
only the AVCodecContext one?

-- 
Anton Khirnov