[FFmpeg-devel] [PATCH v3 1/2] avcodec: add adpcm_ima_ssi encoder

[Zane van Iperen]

On Fri, 10 Apr 2020 12:26:50 +0000
"Zane van Iperen" <zane at zanevaniperen.com> wrote:

> Signed-off-by: Zane van Iperen <zane at zanevaniperen.com>
> ---
>  Changelog              |  1 +
>  doc/general.texi       |  2 +-
>  libavcodec/Makefile    |  1 +
>  libavcodec/adpcmenc.c  | 30 ++++++++++++++++++++++++++++++
>  libavcodec/allcodecs.c |  1 +
>  libavcodec/utils.c     |  1 +
>  libavcodec/version.h   |  2 +-
>  7 files changed, 36 insertions(+), 2 deletions(-)
> 
> diff --git a/Changelog b/Changelog
> index b0c016185e..f84420c6eb 100644
> 
> +    if (avctx->trellis && avctx->codec->id ==
> AV_CODEC_ID_ADPCM_IMA_SSI) {
> +        /*
> +         * Trellis sort-of works, but has some DC offset problems.
> +         * Disable it until I can figure out why.
> +         */
> +        av_log(avctx, AV_LOG_ERROR, "trellis not supported\n");
> +        return AVERROR(EINVAL);
> +    }
> +

Ping.

Also, could someone please clarify something for me?

When encoding, there's no inherit differences between trellis and
non-trellis other then a potentially more-accurate set of nibbles?

And the decoder is none the wiser and chews on them both the same way?

If I'm right, then this looks to be a decoder issue...


Zane