[FFmpeg-devel] [PATCH v2 2/7] lavutil: add dolby vision related header

[mypopy at gmail.com]

On Sat, Apr 11, 2020 at 10:18 PM Jean-Baptiste Kempf <jb at videolan.org> wrote:
>
> I really do not think it is a good idea to have a header with the name dolby in it.
>
Can you give some details, I don't why is a bad idea.
> On Sat, Apr 11, 2020, at 15:44, Jun Zhao wrote:
> > From: vacinfang <vacinfang at tencent.com>
> >
> > add dolby vision related header
> >
> > Signed-off-by: vacinfang <vacinfang at tencent.com>
> > ---
> >  libavutil/Makefile            |  1 +
> >  libavutil/dolby_vision_meta.h | 58 +++++++++++++++++++++++++++++++++++++++++++
> >  2 files changed, 59 insertions(+)
> >  create mode 100644 libavutil/dolby_vision_meta.h
> >
> > diff --git a/libavutil/Makefile b/libavutil/Makefile
> > index 8feb029..9204925 100644
> > --- a/libavutil/Makefile
> > +++ b/libavutil/Makefile
> > @@ -23,6 +23,7 @@ HEADERS = adler32.h
> >                   \
> >            des.h
> >  \
> >            dict.h
> >  \
> >            display.h
> >  \
> > +          dolby_vision_meta.h
> >  \
> >            downmix_info.h
> >  \
> >            encryption_info.h
> >  \
> >            error.h
> >  \
> > diff --git a/libavutil/dolby_vision_meta.h
> > b/libavutil/dolby_vision_meta.h
> > new file mode 100644
> > index 0000000..3fc2cad
> > --- /dev/null
> > +++ b/libavutil/dolby_vision_meta.h
> > @@ -0,0 +1,58 @@
> > +/*
> > + * Copyright (c) 2020 Vacing Fang <vacingfang at tencent.com>
> > + *
> > + * This file is part of FFmpeg.
> > + *
> > + * FFmpeg is free software; you can redistribute it and/or
> > + * modify it under the terms of the GNU Lesser General Public
> > + * License as published by the Free Software Foundation; either
> > + * version 2.1 of the License, or (at your option) any later version.
> > + *
> > + * FFmpeg is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> > + * Lesser General Public License for more details.
> > + *
> > + * You should have received a copy of the GNU Lesser General Public
> > + * License along with FFmpeg; if not, write to the Free Software
> > + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
> > 02110-1301 USA
> > + */
> > +
> > +/**
> > + * @file
> > + * dolby vison configuration
> > + */
> > +
> > +
> > +#ifndef AVUTIL_DOLBY_VISION_META_H
> > +#define AVUTIL_DOLBY_VISION_META_H
> > +
> > +#include <stdint.h>
> > +
> > +/*
> > + * dolby vison configuration
> > + * ref:
> > dolby-vision-bitstreams-within-the-iso-base-media-file-format-v2.1.2
> > +
> > dolby-vision-bitstreams-in-mpeg-2-transport-stream-multiplex-v1.2
> > + * @code
> > + * uint8_t  dv_version_major, the major version number that the stream
> > complies with
> > + * uint8_t  dv_version_minor, the minor version number that the stream
> > complies with
> > + * uint8_t  dv_profile, the Dolby Vision profile
> > + * uint8_t  dv_level, the Dolby Vision level
> > + * uint8_t  rpu_present_flag
> > + * uint8_t  el_present_flag
> > + * uint8_t  bl_present_flag
> > + * uint8_t  dv_bl_signal_compatibility_id
> > + * @endcode
> > + */
> > +typedef struct {
> > +    uint8_t dv_version_major;
> > +    uint8_t dv_version_minor;
> > +    uint8_t dv_profile;
> > +    uint8_t dv_level;
> > +    uint8_t rpu_present_flag;
> > +    uint8_t el_present_flag;
> > +    uint8_t bl_present_flag;
> > +    uint8_t dv_bl_signal_compatibility_id;
> > +} AVDOVIDecoderConfigurationRecord;
> > +
> > +#endif /* AVUTIL_DOLBY_VISION_META_H */
> > --