[FFmpeg-devel] [PATCH v2 1/7] lavc: add a new sidedata type for Dolby Vision

[mypopy at gmail.com]

On Sat, Apr 11, 2020 at 10:55 PM Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
>
> Am Sa., 11. Apr. 2020 um 15:53 Uhr schrieb Jun Zhao <mypopydev at gmail.com>:
> >
> > From: Jun Zhao <barryjzhao at tencent.com>
> >
> > add a new sidedata type for Dolby Vision.
> >
> > Signed-off-by: Jun Zhao <barryjzhao at tencent.com>
> > ---
> >  libavcodec/avpacket.c | 1 +
> >  libavcodec/packet.h   | 9 +++++++++
> >  2 files changed, 10 insertions(+)
> >
> > diff --git a/libavcodec/avpacket.c b/libavcodec/avpacket.c
> > index ad020ee..276beeb 100644
> > --- a/libavcodec/avpacket.c
> > +++ b/libavcodec/avpacket.c
> > @@ -396,6 +396,7 @@ const char *av_packet_side_data_name(enum AVPacketSideDataType type)
> >      case AV_PKT_DATA_ENCRYPTION_INFO:            return "Encryption info";
> >      case AV_PKT_DATA_AFD:                        return "Active Format Description data";
> >      case AV_PKT_DATA_ICC_PROFILE:                return "ICC Profile";
>
> > +    case AV_PKT_DATA_DOLBY_VISION_DECODER_CONF:  return "Dolby Vision";
>
> Should be AV_PKT_DATA_DVISION_DECODER_CONF or similar to be on the safe side
> where it really doesn't matter to change it now.
>
It's ok to change the name, and wait more comments