[FFmpeg-devel] [PATCH v2] avutil/log: update text requesting samples

[Marton Balint]

On Mon, 13 Apr 2020, Carl Eugen Hoyos wrote:

> Am Mo., 13. Apr. 2020 um 00:45 Uhr schrieb Marton Balint <cus at passwd.hu>:
>>
>> Signed-off-by: Marton Balint <cus at passwd.hu>
>> ---
>>  libavutil/log.c | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/libavutil/log.c b/libavutil/log.c
>> index 8d4945249e..965dbca5e1 100644
>> --- a/libavutil/log.c
>> +++ b/libavutil/log.c
>> @@ -466,9 +466,9 @@ static void missing_feature_sample(int sample, void *avc, const char *msg,
>>             "occurs, it means that your file has a feature which has not "
>>             "been implemented.\n");
>>      if (sample)
>> -        av_log(avc, AV_LOG_WARNING, "If you want to help, upload a sample "
>> -               "of this file to ftp://upload.ffmpeg.org/incoming/ "
>> -               "and contact the ffmpeg-devel mailing list. (ffmpeg-devel at ffmpeg.org)\n");
>> +        av_log(avc, AV_LOG_WARNING, "If you want to help, contact "
>> +               "ffmpeg-devel at ffmpeg.org and if requested upload a sample "
>> +               "of this file to https://streams.videolan.org/upload/\n");
>
> Uploading a sample is of course much more important than sending an email,
> so this makes the patch significantly worse imo.

You wrote that we typically ask for samples we already have. So why 
aks for uploading them first?

Regards,
Marton