[FFmpeg-devel] [PATCH] avfilter: add eval video filter

[Paul B Mahol]

On 11/1/19, Michael Niedermayer <michael at niedermayer.cc> wrote:
> On Fri, Nov 01, 2019 at 01:09:24PM +0100, Paul B Mahol wrote:
>> Signed-off-by: Paul B Mahol <onemda at gmail.com>
>> ---
>>  doc/filters.texi         |  78 +++++
>>  libavfilter/Makefile     |   1 +
>>  libavfilter/allfilters.c |   1 +
>>  libavfilter/vf_eval.c    | 687 +++++++++++++++++++++++++++++++++++++++
>>  4 files changed, 767 insertions(+)
>>  create mode 100644 libavfilter/vf_eval.c
>
> This looks like it duplicates code from vf_geq.c
> also this should be integrated with or in vf_geq.c
>
> IIUC this was written because geq is GPL, but i had already agreed to
> relicense the code in it i wrote to LGPL, so iam not sure why you wrote
> this.
>
> Who disagreed to relicnce their contribution to geq to avoid this extra
> work you did ?
> Or did noone disagree ? then i do not understand why you wrote a seperate
> filter

Because geq works with only one input.
Gonna apply this filter immediately.

>
> Thanks
>
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Everything should be made as simple as possible, but not simpler.
> -- Albert Einstein
>